Support MERGE for MySQL connector #24428
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ebyhr
reviewed
Dec 10, 2024
plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/BaseMySqlConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-base-jdbc/src/test/java/io/trino/plugin/jdbc/BaseJdbcConnectorTest.java
Show resolved
Hide resolved
chenjian2664
force-pushed
the
mysql_merge
branch
4 times, most recently
from
b4e8e08 to
c0b86ce
Compare
Is there a test verifying error message when executing MERGE statement on table without primary keys? |
chenjian2664
force-pushed
the
mysql_merge
branch
3 times, most recently
from
a4d84a0 to
3deed31
Compare
chenjian2664
force-pushed
the
mysql_merge
branch
2 times, most recently
from
537b087 to
1146ad7
Compare
|
This pull request has gone a while without any activity. Tagging for triage help: @mosabua |
chenjian2664
force-pushed
the
mysql_merge
branch
2 times, most recently
from
d20d159 to
5b93e35
Compare
|
Dont forget the docs update .. should be an easy one line include now .. |
chenjian2664
force-pushed
the
mysql_merge
branch
from
5b93e35 to
d25cda3
Compare
|
Thank you @chenjian2664 |
ebyhr
reviewed
Jan 16, 2025
plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/BaseMySqlFailureRecoveryTest.java
Outdated
Show resolved
Hide resolved
...ysql/src/test/java/io/trino/plugin/mysql/TestMySqlGlobalTransactionMyConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...ysql/src/test/java/io/trino/plugin/mysql/TestMySqlGlobalTransactionMyConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
...ysql/src/test/java/io/trino/plugin/mysql/TestMySqlGlobalTransactionMyConnectorSmokeTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/BaseMySqlConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/BaseMySqlConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/BaseMySqlConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-mysql/src/test/java/io/trino/plugin/mysql/BaseMySqlConnectorTest.java
Outdated
Show resolved
Hide resolved
plugin/trino-mysql/src/main/java/io/trino/plugin/mysql/MySqlClient.java
Outdated
Show resolved
Hide resolved
plugin/trino-mysql/src/main/java/io/trino/plugin/mysql/MySqlClient.java
Outdated
Show resolved
Hide resolved
chenjian2664
force-pushed
the
mysql_merge
branch
2 times, most recently
from
35191c2 to
527676b
Compare
|
Could you rebase on master to resolve conflicts? |
chenjian2664
force-pushed
the
mysql_merge
branch
from
527676b to
a19e07c
Compare
|
Note that CI is failing due to JDK version up #24786 |
|
Oh, yes, just notice that, are we working on finding a new timezone? |
Co-Authored-By: Yuya Ebihara <[email protected]>
ebyhr
approved these changes
Jan 28, 2025
| if (matcher.matches()) { | ||
| String type = matcher.group(1).toLowerCase(Locale.ENGLISH); | ||
| if (type.contains("varchar") || type.contains("char")) { | ||
| // Mysql requires the primary keys must hava a fixed length, here use the 255 length that is just long enough for the test |
There was a problem hiding this comment.
What happens if the length is insufficient?
There was a problem hiding this comment.
If there are exactly the same prefix(255) data and final in the case is try:
- insert into target, then meet the
Duplicate entry xx for ...error. - update/delete target, then test fails with wrong assert of update count and the expected data.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The tests that are updated in the
BaseJdbcConnectorTestbecause current the implementation of MERGE for Mysql connector requires the table has primary keys, thus modified the table creation logic to usecreateTestTableForWrites, allowing the MySQL connector test class to override it and add primary keys as needed.Release notes